[cordova] add resource-file to mobile-config

[eskan]

Hi,
this PR allow to add resource files, see cordova documentation

there is a feature-request meteor/meteor-feature-requests#279

the added function is
App.addResourceFile(src,target,[platform]);

which will be translated in config.xml :

<platform name="android|ios|both">
  <resource-file src="src.file" target="target" />
</platform>

the App.addResourceFile target parameter is mandatory here as the resource will be copied first at the root of the cordova project. Then cordova builder will copy the file to the target destination.

Why resource-file is need ?

some plugin like cordova-plugin-firebase
need configuration file which is use by Google Services.
here is how to set configuration file for this plugin :

1. Put both google-services.json and GoogleService-Info.plist in your meteor root project
2. Add these lines to your mobile-config.js, APP_NAME should need to be replaced without the real app name

App.addResourceFile('google-services.json', 'src/google-services.json', 'android');
App.addResourceFile('GoogleService-Info.plist', 'APP_NAME/Resources/GoogleService-Info.plist', 'ios');

this will add

<platform name="ios">
    ...
   <resource-file src="GoogleService-Info.plist" target="APP_NAME/Resources/GoogleService-Info.plist"/>
</platform>
<platform name="android">
    ...
    <resource-file src="google-services.json" target="src/google-services.json"/>
</platform>

to the generated config.xml

What is missing ?

Documentation needs to be updated

[benjamn]

@eskan This is looking great to me! Will you be able to update the documentation?

[eskan]

@benjamn "Pas de soucis"
meteor/docs#260

[etyp]

@eskan this is awesome. In the meantime, is there another way to include google-services.json with Meteor Cordova override?

[eskan]

@etyp unfortunately not.

[etyp]

Got it. I managed to add the following to config.xml:

<platform name="android">
    ...
    <resource-file src="google-services.json" target="google-services.json"/>
</platform>

And my google-services.json file by including both of them in the cordova-build-override/ directory. It seems like both were successfully included in .meteor/local/cordova-build but my push plugin still won't work.

Not sure if it's a separate issue, but @eskan is there any reason you can think of for that to not be a temporary workaround? (My assumption is that it doesn't work because of some other unrelated issue)

[eskan]

hi @etyp, it's not a workaround to me as you need to put/change files in a temporary or autogenerated directory. But it could be a way to test notification with your plugin until this PR will be merged.
I get notifications work with the plugin and the configuration mentioned above.

[abernix]

Hmm, is this splitting/popping on resourceFile.src in order to account for the different file path separators on Windows vs Unix, or is this because of something else I'm missing?

If it is because of such a reason, can we use Node's path.parse instead? A backslash is an uncommon, but possible, character in a valid Unix path.

[eskan]

@abernix sorry for this ugly thing, i've updated the PR with path.parse()
regards

[abernix]

Please ignore the "waiting" tests. They will go away if you rebase this off the current devel branch and push, but otherwise, it's simply a side-effect of us switching CircleCI configurations.

[hwillson]

Thanks @eskan - we should be all set here. LGTM!

[abernix]

LGTM.

[brucejo75]

Hey @eskan, is it possible to address #10684.