Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Figure out how to use audit-argument-checks #61

Closed
stubailo opened this issue Dec 17, 2015 · 4 comments
Closed

Figure out how to use audit-argument-checks #61

stubailo opened this issue Dec 17, 2015 · 4 comments

Comments

@stubailo
Copy link
Contributor

Two problems:

  1. SimpleSchema, pending the PR to add a fake check call
  2. I think it doesn't work at all with ES2015 keyword arguments
@stubailo
Copy link
Contributor Author

stubailo commented Jan 5, 2016

Problem 1 is fixed, not problem 2 yet.

@hwillson
Copy link
Contributor

Hi @stubailo - I'm going to work through some of the todos issues backlog, so I'm starting here since it's the oldest.

I took a quick look at the state of audit-argument-checks and how it could be integrated with todos. As you mentioned since Simple Schema now makes the necessary (fake) check call, we're all good there. The second problem you mentioned still seems to be an issue however, so I've submitted PR #178 to help with this. I've adjusted things a bit to keep audit-argument-checks from complaining. These changes aren't as nice in terms of readability as things were, but we can't seem to leverage object/param destructuring the way we want, and have the check call (via Simple Schema) picked up by audit-argument-checks.

Let me know if these changes look okay to you. Thanks!

@hwillson
Copy link
Contributor

I've gone ahead and merged #178 into the Blaze version; I'll get similar changes ready for the react branch shortly.

@hwillson
Copy link
Contributor

I've completed similar changes for react in #181. I'll go ahead and close this (please feel free to re-open if you want to handle things differently). Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants