Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022 reporting #721

Merged
merged 21 commits into from
Oct 6, 2022
Merged

2022 reporting #721

merged 21 commits into from
Oct 6, 2022

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Sep 5, 2022

No description provided.

@dulte
Copy link
Collaborator Author

dulte commented Sep 5, 2022

Two most important failing test:

  • test_read_emep_multiple_dirs: Due to change in reading of multiple years. Time dimension in fake_MSCWCtm_data does not seem to be real years, and therefore fails when xarray tries to concatinate
  • test_read_emep_dummy_data: Fails due to change in definition of concNtno3 in reader

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 80.07% // Head: 79.84% // Decreases project coverage by -0.22% ⚠️

Coverage data is based on head (7429993) compared to base (86f590d).
Patch coverage: 43.61% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev     #721      +/-   ##
============================================
- Coverage     80.07%   79.84%   -0.23%     
============================================
  Files            92       92              
  Lines         16119    16196      +77     
============================================
+ Hits          12907    12932      +25     
- Misses         3212     3264      +52     
Flag Coverage Δ
unittests 79.84% <43.61%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyaerocom/aeroval/glob_defaults.py 100.00% <ø> (ø)
pyaerocom/plugins/mscw_ctm/additional_variables.py 60.00% <26.76%> (-28.10%) ⬇️
pyaerocom/aeroval/coldatatojson_helpers.py 80.32% <50.00%> (+0.03%) ⬆️
pyaerocom/aeroval/coldatatojson_engine.py 83.33% <100.00%> (+0.15%) ⬆️
pyaerocom/aeroval/setupclasses.py 93.44% <100.00%> (+0.03%) ⬆️
pyaerocom/io/read_ebas.py 87.96% <100.00%> (-0.13%) ⬇️
pyaerocom/io/read_eea_aqerep_base.py 85.11% <100.00%> (+0.40%) ⬆️
pyaerocom/plugins/mscw_ctm/reader.py 99.61% <100.00%> (+0.36%) ⬆️
pyaerocom/stationdata.py 82.59% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dulte dulte marked this pull request as ready for review September 26, 2022 11:26
Copy link
Member

@lewisblake lewisblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@dulte dulte merged commit 2c80816 into main-dev Oct 6, 2022
@dulte dulte deleted the 2022-reporting branch October 6, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants