Splitting ColocatedData with the goal of accounting for vertical profiles #727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (mostly failed) attempt at splitting up
ColocatedData
for the eventual inclusion of 3D spatial fields and 4D spatio-temporal fields. Hence this is not a real draft PR, but mostly keeping this here for posterity until we decide how to proceed.The goal was to make
ColocatedData
a parent class and then create derived classesColocatedData2D
andColocatedData3D
. Trying to put everything agnostic to the number of spatial dimensions into the parent classColocatedData
left very little inColcatedData2D
(about 350 lines of code).Daniel and I realized that this is not a trivial task, and discussed what we would want out of "an ideal colocated data class". We for the time being agreed that it would be ideal to only have colocation done on the tuple (lon, lat, alt, time), instead "dimensions" such as the station name. This is geared towards accounting for the vertical profile data and is basically the point-cloud idea Jan has brought up before. We want to discuss this in our next meeting, because creating and entirely new colocated data class is a huge overhaul.