Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ec_n1s #89

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Remove ec_n1s #89

merged 2 commits into from
Sep 5, 2022

Conversation

magnusuMET
Copy link
Collaborator

Adds unit checking for future meteorology

heikoklein
heikoklein requested changes Sep 5, 2022
View reviewed changes
Copy link
Member

@heikoklein heikoklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you still support 'ec_n1s', just internally map it to 'ec_det'? Something like
if (nctype == "ec_n1s") then
write "deprecated nctype ec_n1s used, mapping to ec_det"
nctype = "ec_det"
endif
directly after reading the nctype?

src/common/readfield_nc.f90 Outdated Show resolved Hide resolved
src/common/readfield_nc.f90 Outdated Show resolved Hide resolved
src/common/readfield_nc.f90 Outdated Show resolved Hide resolved
@magnusuMET magnusuMET merged commit 368969e into metno:master Sep 5, 2022
@magnusuMET magnusuMET deleted the remove_ecn1s branch September 5, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heikoklein heikoklein heikoklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnusuMET @heikoklein