Skip to content
This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

Sanity check failure post 01.beta.32 #11

Closed
tfeb opened this issue Aug 22, 2016 · 2 comments
Closed

Sanity check failure post 01.beta.32 #11

tfeb opened this issue Aug 22, 2016 · 2 comments
Assignees
@tfeb
Labels
bug

Comments

@tfeb
Copy link
Contributor

tfeb commented Aug 22, 2016

djq fails sanity with any DREQ post 01.beta.32: what has broken?
@tfeb tfeb added the bug label Aug 22, 2016
@tfeb tfeb self-assigned this Aug 22, 2016
@tfeb tfeb changed the title Sanity check failure post 01.beta.32 Sanity check failure post 01.beta.32 Aug 23, 2016
tfeb pushed a commit that referenced this issue Aug 23, 2016
djq: refactor xlsx comparison code
c94ffe3 
This makes it loadable as a module even when there are horrors, so it
should be easier to find them when there are (as there are now).

This is part of #11
@tfeb
Copy link
Contributor Author

tfeb commented Aug 24, 2016

The problem seems to be that djq thinks that some variables have no MIPs, but they do in the spreadsheet. I am testing against 01.beta.34. One example is the variable with UID 'baa3e4d0-e5dd-11e5-8482-ac72891c3257'.

When I try to use vrev.py I also get no MIPs however.

@tfeb
Copy link
Contributor Author

tfeb commented Aug 24, 2016

So, I rebuilt the spreadsheet using makeTables.py and ... it passes. In other words the spreadsheet in 01.beta.33 and 01.beta.34 does not correspond to the DREQ: djq is right, the spreadsheet is wrong. This is not a bug.

@tfeb tfeb closed this as completed Aug 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tfeb tfeb

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tfeb