Strip-extra-keys should not break on non-map values #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strip-extra-keys-transformer is used for transforming map schemas, but it doesn't check the value being transformed and reduce-kv will fail if given e.g. a string as a value. Non-map values (like strings) are a valid case for :map schema transforming, as they can be decoded into maps. Reitit however has strip-extra-keys transformer before string-decoding, so strip-extra-keys always sees the string value. But I think transformers shouldn't fail like this in any case.
ikitommi
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strip-extra-keys-transformer is used for transforming map schemas, but it doesn't check the value being transformed and reduce-kv will fail if given e.g. a string as a value.
Non-map values (like strings) are a valid case for :map schema transforming, as they can be decoded into maps. Reitit however has strip-extra-keys transformer before string-decoding, so strip-extra-keys always sees the string value. But I think transformers shouldn't fail like this in any case.