Add reitit-frontend support for fragment string #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deraen
force-pushed
the
add-support-for-fragment-parameters-2
branch
from
bac9115
to
a9980b4
Compare
Deraen
changed the title
Deraen
force-pushed
the
add-support-for-fragment-parameters-2
branch
from
a9980b4
to
e89cebe
Compare
ikitommi
approved these changes
Jan 19, 2023
|
|
ikitommi
reviewed
Jan 21, 2023
ikitommi
reviewed
Jan 21, 2023
Deraen
commented
Jan 23, 2023
…t-for-fragment-parameters"" This reverts commit 4d1b00e.
Deraen
force-pushed
the
add-support-for-fragment-parameters-2
branch
2 times, most recently
from
c2ac4bc
to
263dfd1
Compare
Users can use Malli decoding to control decoding per schema.
Deraen
force-pushed
the
add-support-for-fragment-parameters-2
branch
from
263dfd1
to
2494f70
Compare
ilmoraunio
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks #554 to a more generic version.
It is enough that we read the fragment as a string. Users can use Malli coercion with
:decode/stringto decode the fragment values e.g. for the OAuth use-case.There shouldn't be a need for Reitit to provide a function to split those values either, OAuth RFC specifies
application/x-www-form-urlencodedformat, which is supported byring.util.codec/decode-formon Clojure and e.g.URLSearchParamson JS environments.Malli test case shows how to decode the string to a map.
Blocked by malli