Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate build tools #13

Closed
miikka opened this issue Nov 6, 2018 · 3 comments · Fixed by #22
Closed

Consolidate build tools #13

miikka opened this issue Nov 6, 2018 · 3 comments · Fixed by #22

Comments

@miikka
Copy link
Contributor

miikka commented Nov 6, 2018 •
edited
Loading

After merging #10, both deps.edn and Leiningen are used. I think we should pick one.

  • If we go with deps.edn, we need to figure out how to run Clojure tests and deploy releases.
  • If we go with Leiningen, we need to figure out how to use Figwheel to run tests with it.
  • We can also use https://github.com/RickMoynihan/lein-tools-deps to deduplicate information between the two.
@nilern
Copy link
Contributor

nilern commented Aug 26, 2019

I would suggest using Leiningen (as the deps.edn was added just for cljs tests) and using kaocha for the tests.

@miikka
Copy link
Contributor Author

miikka commented Aug 26, 2019

Sounds good and using Kaocha is an excellent idea.

@nilern
Copy link
Contributor

nilern commented Sep 2, 2019

Working on this

@nilern nilern mentioned this issue Sep 3, 2019
Merged
@nilern nilern closed this as completed in #22 Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidation to Kaocha and Leiningen metosin/sieppari
2 participants
@miikka @nilern