Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ClojureScript #3

Closed
ikitommi opened this issue Aug 15, 2018 · 7 comments
Closed

Support for ClojureScript #3

ikitommi opened this issue Aug 15, 2018 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ikitommi
Copy link
Member

No description provided.

@ikitommi ikitommi added the enhancement New feature or request label Aug 15, 2018
@ikitommi ikitommi added the help wanted Extra attention is needed label Sep 5, 2018
@arichiardi
Copy link
Contributor

arichiardi commented Sep 28, 2018 •
edited
Loading

I could help on this, very interested in the interceptor pattern a-la-reframe 😄. I have a question: the AsyncContext protocol requires an await that does not really suits the callback world of JavaScript - it seems blocking. Would it be it a good idea to add something like call-back in case of cljs?

Or something, will come up with an example which is maybe better. Just speculation here 😄

@ikitommi
Copy link
Member Author

Hi, and great to hear about your interest!

What if the whole blocking path would be omitted from cljs? e.g. all code from here on: https://github.com/metosin/sieppari/blob/develop/src/sieppari/core.clj#L77-L82, as there is already the non-blockig / callback-version.

@arichiardi
Copy link
Contributor

That sounds sensible to me!

@ikitommi
Copy link
Member Author

Looking forward to the PR.

@arichiardi
Copy link
Contributor

arichiardi commented Oct 7, 2018 •
edited
Loading

PR #10 is in progress - seeking advice on the tests

@arichiardi
Copy link
Contributor

PR #10 has been merged to develop

@ikitommi
Copy link
Member Author

ikitommi commented Nov 9, 2018

shipped in 0.0.0-alpha6, big thanks! I think we should push a real version out soon.

@ikitommi ikitommi closed this as completed Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ikitommi @arichiardi