Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non AsyncContext & map-like contexts should fail fast #41

Open
ikitommi opened this issue May 14, 2020 · 2 comments
Open

Non AsyncContext & map-like contexts should fail fast #41

ikitommi opened this issue May 14, 2020 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ikitommi
Copy link
Member

Currently, if a context is neither, it will do something undefined, most likely fails, but could just do nothing. If it's neither, we should blow up in a manged way, relevant code here: https://github.com/metosin/sieppari/blob/develop/src/sieppari/core.cljc#L36-L43

This happens for example when someone returns a core.async channel, without having it registered as a valid AsyncContext.

@ikitommi ikitommi added bug Something isn't working help wanted Extra attention is needed labels May 14, 2020
@ikitommi
Copy link
Member Author

should be easy to fix, just change default protocol mappings to all map-like things and if -> cond.

@tvaisanen
Copy link
Contributor

Looks like this one has already been fixed by: 2fdfe73#diff-0f6d587492626373d113ac119d5a735853fe1fb9212914a941858e4051269b08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants