Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up our wild use of conditional compilation. #47

Open
tobz opened this issue Jun 17, 2021 · 0 comments
Open

Clean up our wild use of conditional compilation. #47

tobz opened this issue Jun 17, 2021 · 0 comments

Comments

@tobz
Copy link
Member

tobz commented Jun 17, 2021

Conditional compilation is a necessity for targeting different platforms, although at this point, we've found ourselves down quite the rabbit hole in terms of how Cargo.toml and src/monotonic.rs look.

We should spend some time trying to clean this up where we can. On the code side, we might be better off splitting out the various architecture-specific implementations of Monotonic into dedicated files. As far as Cargo.toml, that one is dicey, but perhaps there's some magic we can exploit there to do it in a cleaner fashion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant