Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Story] Halting of Music After the Image has Been Closed or a New Image is Played #73

Closed
1 of 5 tasks
Kelzihar opened this issue Oct 9, 2021 · 2 comments
Closed
1 of 5 tasks
Assignees
Labels
enhancement New feature or request user story User Story

Comments

@Kelzihar
Copy link

Kelzihar commented Oct 9, 2021

User Story

Essential components

  • Title describes the story
  • Stakeholder type is identified
  • Outcome is described
  • Rationale is explicit
  • Acceptance criteria are verifiable and from the perspective of the stakeholder

Story

As a user
I want the image's music to stop when an image is closed or a different image is played
so that only one image's music plays at a time and cannot overlap each other

Acceptance Criteria

(Rules or scenarios are acceptable formats.)

  • When using file -> close | if the image that was closed had music playing, the music halts or stops
  • When using file -> play | when two different images are up, if music is already playing from one image, the music currently playing halts and the most recent play starts as the only music occurring
  • When using file -> play | multiple times on one image, the music does not overlap, the current playing halts and the most recent file -> play is done

Supporting Information

Currently the music will continue to play when the image has been closed and will end either when it reaches the end of the song or when the program is closed through file -> close. This issue is most seen on the hiroshige.gif file in the images directory as the music played from this file is quite long.

@Kelzihar Kelzihar added the user story User Story label Oct 9, 2021
@Kelzihar Kelzihar changed the title Halting of Music After the Image has Been Closed or a New Image is Played [User Story] Halting of Music After the Image has Been Closed or a New Image is Played Oct 9, 2021
@jody jody added enhancement New feature or request invalid This doesn't seem right labels Oct 9, 2021
@jody
Copy link
Contributor

jody commented Oct 9, 2021

This "User Story" appears to presume a behavior that doesn't match with the current behavior (at least when tested on macOS). In particular, once the Play action is selected the picture windows do not respond to menu item requests. This also means that it is not currently possible to begin playing a second image at the same time (such as for a duet).

Perhaps there is an intent for multiple other changes to be inferred that would provide the context for this story. If so, please write those user stories explicitly. Then this user story might be added that will build on such a product.

@jody
Copy link
Contributor

jody commented Oct 12, 2021

Investigations suggest that the behavior is likely dependent on the version of Java used in the build of imageLab.

In particular, the current release (v1.8.3) of imagelab.jar distributed via https://metrocs.github.io/imagelab/ does not appear to provide the ability to close a window or activate other windows during "play".

Builds of the current repository code under Java version 11 or later do appear to allow interaction with imageLab windows while "play" is ongoing; the behavior described in this issue.

This suggests the existence of another substantive issue involving associating particular versions of imageLab with particular versions of Java.

@jody jody removed the invalid This doesn't seem right label Oct 18, 2021
@jody jody closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user story User Story
Projects
None yet
Development

No branches or pull requests

2 participants