Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary16: add conversion to and from big.Float #14

Merged
merged 13 commits into from
Aug 27, 2018
Merged

binary16: add conversion to and from big.Float #14

merged 13 commits into from
Aug 27, 2018

Conversation

mewmew
Copy link
Owner

@mewmew mewmew commented Aug 27, 2018

This PR updates the binary16 implementation to use big.Float conversion vesicle. The intention is to consolidate the implementation of binary16, binary128, float80x86 and float128ppc to convert back and forth between big.Float, so that libraries may be build on top of these to provide consistent floating-point operations.

One such user is github.com/llir/llvm/ir/constant.

Add extensive test cases for binary16.

@mewmew
Copy link
Owner Author

mewmew commented Aug 27, 2018

@alexpantyukhin Haha, quick reaction :)

@coveralls
Copy link

coveralls commented Aug 27, 2018

Pull Request Test Coverage Report for Build 41

  • 101 of 109 (92.66%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.6%) to 93.233%

Changes Missing Coverage Covered Lines Changed/Added Lines %
binary16/binary16.go 101 109 92.66%
Files with Coverage Reduction New Missed Lines %
binary16/binary16.go 3 93.29%
Totals Coverage Status
Change from base Build 33: 2.6%
Covered Lines: 248
Relevant Lines: 266

💛 - Coveralls

@mewmew mewmew merged commit 67c4a74 into master Aug 27, 2018
@mewmew mewmew deleted the dev branch August 27, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants