Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper for hyperbolic class and fixing ex18 #227

Closed
justinlaughlin opened this issue Jul 1, 2024 · 3 comments
Closed

Wrapper for hyperbolic class and fixing ex18 #227

justinlaughlin opened this issue Jul 1, 2024 · 3 comments

Comments

@justinlaughlin
Copy link
Contributor

mfem/mfem#3598 introduced a new class DGHyperbolicConservationLaws and refactored ex18.cpp and ex18p.cpp.

The new implementation leads to ex18.py failing; the solutions are very similar but different enough to not pass. For example

  • differences in time-stepping due to (I believe) changes in GetMaxCharSpeed result in 435 time-steps to reach t=2.0 rather than 437.
  • Meshes/solutions were renamed from "vortex-..." to "euler-..."

I'll start branch to wrap the new hyperbolic conservation class and update ex18

@justinlaughlin justinlaughlin mentioned this issue Jul 1, 2024
12 tasks
@justinlaughlin
Copy link
Contributor Author

@sshiraiwa
Copy link
Member

@justinlaughlin
I started from fix-ex18 and rebased it use mfem_47_dev as a base.
https://github.com/mfem/PyMFEM/tree/fix-ex18-v2
I added hyperbolic.i for serial and parallel (build passed, not used yet from ex18).

I will take a look at ex18

@sshiraiwa
Copy link
Member

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants