New release

[tlocke]

I think all the outstanding bugs have been fixed, so do we think it's time for a new release? I'm not totally sure what's involved. @mfenniak, is there anything I can do to help things along?

[mfenniak]

Sounds like a good idea. I don't have any notes or good memory of what needs to be done for a release, but I will take care of this, and I'll keep track of whatever is involved. Please pester me in a few days if I go silent and forget about this before I get it done. ;-)

[tlocke]

Sorry closed the issue by mistake !!!??!!!!!!!!

I've made the py3 branch work on Python 2 as well and I've merged the trunk branch into it to keep the history of trunk. I then deleted the 'trunk' name and renamed 'py3' to 'master' as this is more familiar for Git users. The resulting master branch is at https://github.com/tlocke/pg8000/tree/master. I've tested master on all the Python versions we support (2.5, 2.6, 2.7, 3.2, 3.3, PyPy and Jython). It makes use of the six library, but it's included in the source rather than as a dependency.

I think that having a single version will make the release a bit easier, and it'll also mean less duplication of effort with bug fixes and new features.

Don't worry, I haven't changed anything on the main repository, just pull it if you like it :-)

[mfenniak]

So, I totally didn't read your last message on this issue until now when your PR caught my eye. :-) Sorry for letting you sit in limbo for a couple weeks on that branch. Merging PR #24 will definitely make putting out a new release easier.

Regarding that... I think what I might do about this issue is, rather than doing the release, make it so that you can do it. While I'd still like to be affiliated with this project, it's obvious that my interest level in it is very low relative to yours.

What do you think would be required for that? My first thoughts are PyPI access to pg8000, and access to the pg8000 website (http://pybrary.net/pg8000/). The latter of which there might be better options these days than hosting a static website... readthedocs, or GitHub pages, or something along those lines.

[tlocke]

Right, I've now pushed the master branch to mfenniak/pg8000. I've removed the 'py3' branch marker, but all the historical code is still there because it's a parent of a commit on the 'master' branch. @mfenniak, in the github repository settings for pg8000, could you make the 'master' branch the default, rather than trunk? Then I can remove the 'trunk' label. Thanks!

[mfenniak]

Changed the default branch to "master".

[tlocke]

Cool, thanks. I've removed the 'trunk' branch (but code still there because it's part of master branch). We've now got a unified Python 2 and 3 codebase. Yay!

I'm working on the docs now. Reading up on PyPi, I've found that it has its own doc hosting service:

https://wiki.python.org/moin/PyPiDocumentationHosting?action=show&redirect=PyPiHostingDocumentation

So I think that may be the way to go. I've got an account on PyPi called 'tlocke', is it possible to give me permissions for pg8000?

[tlocke]

I think things are in good shape for the new release. Hopefully it's not too controversial but I've made the following two changes:

• Everything (functions, properties, classes) is now available under the pg8000 namespace. The old locations still work for backward compatibility
• For Python 3, the bytes type replaces the pg8000.Bytea type. For backward compatibility the pg8000.Bytea still works under Python 3.

To make sure the changes are truly backward compatible, I've taken a copy of the 1.8 tests and put them in a subdirectory of the 'tests' directory.

I think the next step is to upload to PyPi. I think it's a matter of doing:

python setup.py sdist upload

and then uploading the docs using:

python setup.py upload_docs

Can you do that @mfenniak ? Or I can do it if you're able to give me permissions.

[mfenniak]

Those changes sound good to me.

I seem to have lost the ability to login to my PyPI account. 😬 I'm trying to contact someone with PyPI and see if they can help me out. I'll let you know as soon as I get that issue resolved; sorry!

[mfenniak]

Ok, pypi issue resolved. I've added tlocke as a maintainer of the pypi pg8000 project, hopefully that's your username. :-)

[tlocke]

Excellent @mfenniak, thanks, I'll get on to it tomorrow.

[tlocke]

Well, I've released it! It's at:

https://pypi.python.org/pypi/pg8000/

and the docs are at:

http://pythonhosted.org/pg8000/

Perhaps we should announce it somewhere?

[simonh10]

Hi,
The updated package on pypi seems to have broken connectivity to an existing database. This issue seems to effect version 1.9.1 and 1.9.0, but works fine when I roll back to 1.09. I'm using it within sqlalchemy.

"/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pg8000/core.py", line 1472, in handle_messages
self._sock.read(data_len - 4), prepared_statement)
File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pg8000/core.py", line 1441, in handle_COMMAND_COMPLETE
row_count = int(values[-1])
ValueError: invalid literal for int() with base 10: 'SELECT'

postgresql version 8.4.13

[tlocke]

Hi @simonh10, I reproduced your bug and I've committed a fix at cff9d60. It's such a serious bug that I've also done a new release 1.9.2, which is available on PyPi.

[simonh10]

That's excellent thanks i'll roll it into a test deploy from pypi in the morning and see how it goes.

[tlocke]

Hi @mfenniak I notice that in the title of the repository at https://github.com/mfenniak/pg8000 there's a link to http://pybrary.net/pg8000/. Could you remove it because the latest docs are at http://pythonhosted.org/pg8000/ ? Thanks!

[mfenniak]

Updated. 👍

[tlocke]

Great, thanks. I think I'll close this issue now.