Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common header file (suggestion) #58

Closed
accelerated opened this issue Apr 23, 2018 · 3 comments
Closed

Common header file (suggestion) #58

accelerated opened this issue Apr 23, 2018 · 3 comments

Comments

@accelerated
Copy link
Contributor

Would be nice to have a single header file which includes everything one might need when using cppkafka instead of including several header files. This common header should also include the util classes. It would be similar to rdkafka.h for instance. It's always easier to just include a single file and not have to worry about other dependencies.

suggestion: cppkafka/cppkafka.h

Thoughts?

@mfontanini
Copy link
Owner

Sounds good! Ideally this would be generated automatically by CMake as otherwise it's hard to maintain manually otherwise. I don't think that would be too hard to implement but I'm not sure. Otherwise a manually generated header would work for now.

@accelerated
Copy link
Contributor Author

Didn't think about the auto gen header but that sounds even better. With cmake you can GLOB files. I will look into that and submit a PR.

@mfontanini
Copy link
Owner

Yeah, that should work. Also probably sort them (I imagine CMake has a sort function) so it's consistent across platforms and new files don't alter the entire list of headers' order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants