Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Fields #19

Closed
mfrost503 opened this issue Jan 18, 2015 · 1 comment
Closed

Post Fields #19

mfrost503 opened this issue Jan 18, 2015 · 1 comment
Assignees
Milestone

Comments

@mfrost503
Copy link
Owner

So Twitter API does this really stupid thing, where it requires any post fields to be added to the base string for the signature generation. The encoding seems a little bit different than the rest of the string...I feel like I had this working at one point...however it's not working right now.

It looks like they get tacked onto the end of the base string, key sorted alphabetically and weirdly encrypted. I'm not sure how many OAuth 1 APIs share this same strategy, I don't believe I've seen any. It was an easy enough tack on, so could Twitter could be used with an otherwise spec compliant library. Seems superfluous and unnecessary and doesn't really add much security...but it is what it is I suppose.

@mfrost503 mfrost503 self-assigned this Jan 18, 2015
@mfrost503 mfrost503 added this to the 1.0.0 milestone Jan 18, 2015
@mfrost503
Copy link
Owner Author

Turns out Snaggle is handling this correctly, the issue when actually using this functionality is that the OAuth aspect of the post fields in the Twitter API requires they be rawurlencoded prior to being added (they get encoded again) - the actual request requires them to be not rawurlencoded. Minus a little clean up and a few tests (which didn't exist before I guess), this should be ready for 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant