rewrite Qt library frontend #2570
Conversation
|
Unsure it's related, but I got this warning when testing: |
It's related. Checking, I see it too. Haven't pinpointed it yet. I'll hook up QAbstractItemModelTester and see if it sheds light on it. |
|
Rebased in order to pick up the platform icons. |
|
Possible addition: https://github.com/ahigerd/mgba/pull/1/files I don't know if this is a good idea or not, so I'm keeping it separate until it can be reviewed. |
|
Oops. Forgot to add the new icons to the qrc. |
|
Can you rebase this on current master? |
ahigerd
force-pushed
the
alh/library
branch
2 times, most recently
from
a35d44f
to
8e484ac
Compare
ahigerd
force-pushed
the
alh/library
branch
2 times, most recently
from
964b303
to
93bf6d2
Compare
ahigerd
force-pushed
the
alh/library
branch
3 times, most recently
from
318ccb2
to
e4cc3c2
Compare
|
Please rebase |
| QString path = m_pathOrder[index.parent().row()]; | ||
| entry = m_pathIndex[path][index.row()]; | ||
| } else if (!index.parent().isValid() && index.row() < m_games.size()) { | ||
| entry = &m_games[index.row()]; |
There was a problem hiding this comment.
Note to self: something's weird with the indentation here.
I've ripped out the existing implementation for the Qt library frontend and replaced it with a QAbstractItemModel. This should improve performance significantly. I've added some additional functionality along the way, like some reasonable behavior on window resizing and storing view configuration in the settings.
The grid view isn't implemented yet, obviously (but it wasn't available for selection in the settings, either), and I haven't removed LibraryGrid from the repository for future reference.