Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen does not update #3

Closed
khuongduybui opened this issue Nov 8, 2014 · 9 comments
Closed

Screen does not update #3

khuongduybui opened this issue Nov 8, 2014 · 9 comments

Comments

@khuongduybui
Copy link

I checked out the source code and run without any modifications.
I connected to a VNC server successfully, but when I move or click the mouse or type something with the keyboard, the screen is not updated. I tried to put "console.trace()" into server.js #handleFrame() function and found out that it was never called more than once in the whole 15 minutes.

Note: I connect to a real VNC service on another VM on the same host, so network latency is absolutely out of question.

@mgechev
Copy link
Owner

mgechev commented Nov 9, 2014

Thanks for the issue! Next a couple of days I'm going to debug it and see how it could be fixed.

@mgechev
Copy link
Owner

mgechev commented Nov 13, 2014

The installation of node-png is a little bit tricky. In order to make it run you need libpng and I think you cannot compile it with the latest node, so you will need not newer version than ~0.10.13.

After making node-png running, everything should work properly.

@mgechev mgechev closed this as completed Nov 13, 2014
@khuongduybui
Copy link
Author

I had all dependencies installed and the screen loads successfully upon login. It just doesn't "update".
I tried putting r.requestUpdate(...) into the r.on('rect') handler but even that is still very sluggish.
Note: the VNC server I test this with is running TightVNC server version 1.2.9

@mgechev mgechev reopened this Nov 14, 2014
@mgechev
Copy link
Owner

mgechev commented Nov 14, 2014

I'm going to keep the issue open, hopefully I'll be able to reproduce it.

@haroondilshad
Copy link

The screen doesn't update, same here.

@haroondilshad
Copy link

Can't find anywhere emitting .emit('rect',rect), maybe that's the problem?

@mgechev
Copy link
Owner

mgechev commented Dec 7, 2014

Today I found time and reproduced the issue.

I tried to connect to TightVNC server but it didn't work. I guess there was a problem in the frame encoding or may be security?

With RealVNC it works properly. I also added polling for changes, the polling is not incremental i.e. every time the proxy requests the whole screen. In order to make it incremental change the flag passed to requestUpdate.

@mgechev mgechev closed this as completed Dec 7, 2014
@haroondilshad
Copy link

I'm trying it on RealVNC but the issue is produced

@mgechev
Copy link
Owner

mgechev commented Dec 7, 2014

@RonCan did you pull the last changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants