Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useFactory with Lambda fails #66

Closed
josephliccini opened this issue Nov 5, 2019 · 1 comment
Closed

useFactory with Lambda fails #66

josephliccini opened this issue Nov 5, 2019 · 1 comment

Comments

@josephliccini
Copy link

Hi Minko,

This tool is awesome! I'm super impressed with how easy it makes it to visualize a complex Angular application.

To get it to work in our app, we had to do some refactoring in a few places where we use the useFactory notation.

I think this picture will be more useful than me trying to explain it:
image

This syntax for providers is supported in Angular 6+ (maybe 7?) so I expected it to work with NGRev.

With the refactoring above, we were able to generate the report.

Thanks!

@mgechev
Copy link
Owner

mgechev commented Dec 30, 2020

There's an ongoing effort to update the app to be compatible with Ivy. As part of this, we'll also fix the problem here. Closing the issue for now.

@mgechev mgechev closed this as completed Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants