Add --ignore flag to ignore files/directories

[takos22]

Add --ignore flag to ignore files/directories
Alias -I, can be used multiple times

[mgedmin]

Thank you, this looks good! For this to be merged, I'd like to see some tests for the new feature, and maybe a one-line note in the changelog.

[takos22]

Done the changes

[mgedmin]

Excellent! Now the only missing thing is unit tests for the new code:

Name             Stmts   Miss  Cover   Missing
----------------------------------------------
findimports.py     525      2    99%   434, 436
----------------------------------------------
TOTAL              525      2    99%
Coverage failure: total of 100 is less than fail-under=100

It would be easier to write the tests after some refactoring of the code. I would extract the filtering logic into a separate method:

    def filterIgnoes(self, dirs, files, ignores):
        for ignore in ignores:
            if ignore in dirs:
                dirs.remove(ignore)
            if ignore in files:
                files.remove(ignore)

call it inside parsePathname(), and then write a test like

    def test_filterIgnores(self):
        dirs = ['venv', 'submodule']
        files = ['code.py', 'README.txt']
        mg = findImports.ModuleGraph()
        mg.filterIgnores(dirs, files, ignores=['venv', 'README.txt'])
        self.assertEqual(dirs, ['submodule'])
        self.assertEqual(files, ['code.py'])

in tests.py, next to the parsePathname test.

[takos22]

I was busy lately but I will try to make the changes tomorrow.

[mgedmin]

There's no rush! ;)

[takos22]

Separated the logic in ModuleGraph.filterIgnores, added tests, updated the docstring in findimports.py, bumped the version to 0.2.1 and added a short description in CHANGES.rst. Could you review again?

[mgedmin]

Looks good to me!

[mgedmin]

Oh wow, and I'd totally forgotten that there was a usage message in the docstring! Thank you for noticing and updating it!

(This code is old, these days I'd rely on argparse-generated help messages, and maybe put a copy in the README for new user convenience, and then usually forget to update it when making changes.)

[takos22]

I'm making modules too so I know the feeling when I forget to update docs 😅

[mgedmin]

I've pushed a new release to PyPI.