Experiment: render HTML logs dynamically #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing pieces: - error handling when the log file doesn't exist - next/prev/index navigation - rendering the index page - making it possible to customize the style/colors/title format/etc
mgedmin
force-pushed
the
dynamic-html
branch
from
ef916a6
to
727afd1
Compare
Users of various style classes had to take extreme care not to let the style instance be garbage collected, because that would close the underlying stream buffer (which destroys the data of a BytesIO()). There's a way to avoid all that cumbersome and non-intuitive dance: call TextIOWrapper.detach() so that the TextIOWrapper won't close the underlying buffer in its __del__.
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10.
Missing pieces: