Skip to content

Commit

Permalink
Update release.mk to 1.3
Browse files Browse the repository at this point in the history
  • Loading branch information
mgedmin committed Nov 8, 2018
1 parent 2336aa6 commit 318c13f
Showing 1 changed file with 14 additions and 7 deletions.
21 changes: 14 additions & 7 deletions release.mk
@@ -1,4 +1,4 @@
# Makefile.rules version 1.1 (2017-12-20)
# release.mk version 1.3 (2018-11-03)
#
# Helpful Makefile rules for releasing Python packages.
# https://github.com/mgedmin/python-project-skel
Expand All @@ -11,7 +11,8 @@ CHANGELOG_FORMAT ?= $(changelog_ver) ($(changelog_date))

# These should be fine
PYTHON ?= python
PYPI_PUBLISH ?= rm -rf dist && $(PYTHON) setup.py -q sdist bdist_wheel && twine upload dist/*
PYPI_PUBLISH ?= rm -rf dist && $(PYTHON) setup.py -q sdist bdist_wheel && twine check dist/* && twine upload dist/*
LATEST_RELEASE_MK_URL = https://raw.githubusercontent.com/mgedmin/python-project-skel/master/release.mk

# These should be fine, as long as you use Git
VCS_GET_LATEST ?= git pull
Expand Down Expand Up @@ -54,7 +55,7 @@ distcheck-sdist:
$(VCS_EXPORT) && \
cd tmp && \
tar -xzf ../dist/$$pkg_and_version.tar.gz && \
diff -ur $$pkg_and_version tree -x PKG-INFO -x setup.cfg -x '*.egg-info' && \
diff -ur $$pkg_and_version tree -x PKG-INFO -x setup.cfg -x '*.egg-info' -I'^#' && \
cd $$pkg_and_version && \
make dist check && \
cd .. && \
Expand All @@ -64,13 +65,16 @@ distcheck-sdist:
cd ../two/ && \
tar -xzf ../$$pkg_and_version/dist/$$pkg_and_version.tar.gz && \
cd .. && \
diff -ur one two -x SOURCES.txt && \
diff -ur one two -x SOURCES.txt -I'^#:' && \
cd .. && \
rm -rf tmp && \
echo "sdist seems to be ok"

# NB: do not use $(MAKE) because then make -n releasechecklist will
# actually run the distcheck instead of just printing what it does
.PHONY: check-latest-rules
check-latest-rules:
ifndef FORCE
@curl -s $(LATEST_RELEASE_MK_URL) | cmp -s release.mk || { printf "\nYour release.mk does not match the latest version at\n$(LATEST_RELEASE_MK_URL)\n\n" 1>&2; exit 1; }
endif

.PHONY: check-latest-version
check-latest-version:
Expand All @@ -91,8 +95,11 @@ check-changelog:
grep -q "^$$ver_and_date$$" $(FILE_WITH_CHANGELOG) || { \
echo "$(FILE_WITH_CHANGELOG) has no entry for $$ver_and_date"; exit 1; }

# NB: do not use $(MAKE) because then make -n releasechecklist will
# actually run the distcheck instead of just printing what it does

.PHONY: releasechecklist
releasechecklist: check-latest-version check-version-number check-long-description check-changelog
releasechecklist: check-latest-rules check-latest-version check-version-number check-long-description check-changelog
make distcheck

.PHONY: release
Expand Down

0 comments on commit 318c13f

Please sign in to comment.