Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdaBound #4

Closed
r1ckya opened this issue Aug 27, 2019 · 6 comments
Closed

AdaBound #4

r1ckya opened this issue Aug 27, 2019 · 6 comments
Labels
wontfix This will not be worked on

Comments

@r1ckya
Copy link

r1ckya commented Aug 27, 2019

Hi, thanks for great work.
Would you also consider checking out AdaBound optimizer? It claims to be

as fast as Adam and as good as SGD

It seems worth to put it to the test and combine with other techniques.
https://github.com/Luolc/AdaBound

@mgrankin
Copy link
Owner

Hello, have you used AdaBound? Is there any rule of thumb on how to tune final_lr?

@r1ckya
Copy link
Author

r1ckya commented Aug 28, 2019

I didn't yet. Not that I'm aware of, but final_lr is in a sense SGD lr and lr is Adam lr. So maybe running lr_finder with SGD first makes sense.

@mgrankin
Copy link
Owner

Have you tried to run AdaBound? I'm getting

ZeroDivisionError: float division by zero

It seems that base_lrs aren't initialised properly. What should they be?

@r1ckya
Copy link
Author

r1ckya commented Sep 12, 2019

Yes, I have. Didn't see this error. I have used this version.
https://github.com/Luolc/AdaBound/blob/master/adabound/adabound.py
base_lrs shouldn't be zero because group['lr'] != 0
self.base_lrs = list(map(lambda group: group['lr'], self.param_groups))

@mgrankin
Copy link
Owner

I think the error I've received was due to LR scheduling. @r1ckya which LR schedule do you use?

@stale
Copy link

stale bot commented Feb 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 2, 2020
@stale stale bot closed this as completed Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants