Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack/unpack approach #52

Closed
mgree opened this issue Oct 2, 2021 · 1 comment · Fixed by #65
Closed

Pack/unpack approach #52

mgree opened this issue Oct 2, 2021 · 1 comment · Fixed by #65
Assignees
Labels
enhancement New feature or request

Comments

@mgree
Copy link
Owner

mgree commented Oct 2, 2021

Just load/unload data directly on the filesystem.

Progress indicator. https://docs.rs/indicatif/0.16.2/indicatif/

Multithreading? (Is that ever a performance win?)

Pack

BFS?

Unpack

Flag to follow symlinks, possibly even out of the root.

-i flag for prompting on weirdness.

@mgree mgree added the enhancement New feature or request label Oct 2, 2021
@mgree mgree mentioned this issue Oct 7, 2021
@mgree
Copy link
Owner Author

mgree commented Feb 1, 2023

Plan/milestones for @nad2040:

  • install locally, get it working
  • build locally
  • read and understand format.rs
  • unpack : json (or whatever) -> FS
    • be careful about overwriting things (inspired by tar flags)
    • write tests as you go (maybe a separate directory, same strategy)
  • pack
    • be careful following symbolic links and moving outside of the directory tree (cf. tar or find)
    • loop detection
    • write tests as you go (start integrating, i.e., test pack and unpack together)

Long term goals:

  • pack/unpack executables which support (nearly) identical CLI options
  • tests work the same (mutatis mutandis)
  • round trip property
  • write tests comparable to jq
  • microbenchmarks vs. ffs and vs jq (and vs gron?)

@nad2040 nad2040 mentioned this issue Aug 17, 2023
@nad2040 nad2040 linked a pull request Aug 17, 2023 that will close this issue
@mgree mgree closed this as completed in #65 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants