You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @ontl. No plans yet, when I created this XML handling was not even really specified of course you can send a PR to improve the API. I would like it to be covered with tests though.
I think we should try not to make the translate() API too complex with so many new options. Perhaps we can encapsulate the XML related options somehow together in one new parameter containing the different fields, what do you think?
Ok cool. I have a working version with just the tag_handling=xml param, and have been poking away at some tests (on short strings, the normal translation mode sometimes produces the same results as tag_handling=xml, so still looking for the best test strings)
To add the other XML-related options, I like your idea of encapsulating them rather than adding more options to translate(). I'm a bit rusty in python, is the idea we'd add an xml_options parameter to translate() which expects a dict of options? What would the command line syntax look like for that, --xml_options={option1:value,option2:value}?
Do you have plans to add support for XML tag handling? Would you be open to a PR adding it?
The text was updated successfully, but these errors were encountered: