Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version updated to 2.7 Css converted to GSS #284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guivanrv
Copy link

I've completed the CSS to GSS migration for those who want to use MGWT with his 2.8.0 project, or simply with GSS support enabled in 2.7 - feel free to use one from my fork

@paulfrench
Copy link

Thanks for the pull request at first glance looks great. I'm guilty of this myself, but on such a large commit that changes many files it would have been better to leave the files named ".css" and rename them to ".gss" in a second commit. It would make it a lot easier to review the relevant more interesting changes. Also there seems to be a lot of unnecessary minor format changes, like the removal of a space after a comma. Anyway, thanks for the pull request, it would certainly make sense to merge into master. I'll wait for others to comment as well since it would probably mean minor changes to peoples applications that use MGWT that extend appearances for example defined in MGWT. Cheers!

@waynedyck
Copy link

I'll try and step through all of this over the next week or so and try it with a few projects to see if there are any issues.

In addition to Paul's comments, for future pull requests on this or any project, you'll want to create a separate branch rather than using your fork's master branch. Your fork's master branch should be kept pristine so you can merge in changes from the main upstream branch.

Have a look at GitHub's Fork A Repo documentation.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants