Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnregisterHotKey not implemented #2004

Closed
Athanasius opened this issue Jan 15, 2023 · 5 comments
Closed

UnregisterHotKey not implemented #2004

Athanasius opened this issue Jan 15, 2023 · 5 comments

Comments

@Athanasius
Copy link

UnregisterHotKey, the counterpart to RegisterHotKey (which is implemented in win32gui), doesn't appear to be implemented in pywin32 at all.

At least I can't find the string UnregisterHotKey anywhere in a git clone or in the shipped DLLs.

@Athanasius
Copy link
Author

NB: As I work through the ctypes code I'm migrating to pywin32 (to more easily fix the few issues we have on 64-bit Windows) I might find some other missing implementations as well. Do you want an issue for each ?

@mhammond
Copy link
Owner

Do you want an issue for each ?

I don't think one issue for every Windows function that's not in pywin32 makes much sense - there would be a massive number. There's also not much of a chance someone will implement them just because an issue is open - so really, a PR which implements them is what would be the most effective strategy.

@Athanasius
Copy link
Author

That assumes that someone trying to use pywin32 has the skills and knowledge to correctly program an implementation in the paradigm of pywin32.

In this specific case it seems strange to implement RegisterHotKey but not UnregisterHotKey.

@mhammond
Copy link
Owner

I agree, but it still takes a PR to get resolved.

@mhammond
Copy link
Owner

Fixed by #2185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@mhammond @Athanasius and others