Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

column 'Mosaic_ID' correct information? #27

Closed
lmorabit opened this issue Feb 1, 2018 · 14 comments
Closed

column 'Mosaic_ID' correct information? #27

lmorabit opened this issue Feb 1, 2018 · 14 comments

Comments

@lmorabit
Copy link

lmorabit commented Feb 1, 2018

I'm looking at LOFAR_HBA_T1_DR1_merge_ID_optical_v0.4.fits and it seems that somehow the column 'Mosaic_ID' is not properly catching the Mosaic_ID -- some are fine, with P214+55 but then there are columns where it's just 'P10Hetde' or 'P1Hetdex1' ... what's going on here? Is there a standard format that we should be following for the mosaic IDs or are they listed somewhere that's accessible?

@twshimwell
Copy link
Collaborator

twshimwell commented Feb 1, 2018

The P10Hetde or P1Hetdex1 (these are truncated which I thought we had fixed...) are the pointing names in the LTA. The naming convention was changed after cycle two to e.g. P214+55 which explains the mix. I'd have thought best to leave the LTA names (not truncated though)

@mhardcastle
Copy link
Owner

Yes, this is the result of truncation of this field in @twshimwell's original catalogue (I think it is still truncated but less so in more recent versions -- which means we have a mix in the final catalogue depending on where the data came from, e.g. there is both 'P10Hetde' and 'P10Hetdex'.

I worked round this so long ago that I guess I forgot it was an issue!

@twshimwell
Copy link
Collaborator

Ah, I thought I had fixed the truncation now.

@lmorabit
Copy link
Author

lmorabit commented Feb 1, 2018

So will it get updated in the next version of the catalogue? I think Catherine is trying to use this information for her project.

@mhardcastle
Copy link
Owner

I think you're still a couple of characters off, Tim (but we should check what we're using).

What we have is almost always enough to identify the mosaic without using the RA, Dec...

Leah: yes we should update in the next version. Thanks for pointing it out.

@mhardcastle
Copy link
Owner

(For what I do I have code that just makes a subimage from the required mosaic which it finds by going through RA, Dec and ignoring this field altogether. Maybe that doesn't work for Catherine though.)

@twshimwell
Copy link
Collaborator

yeh indeed my names are truncated. For the Hetdex names do you want e.g.

P11Hetdex12 or just P11Hedex

There is also just P6 which doesnt have Hetdex in the name. Should I just leave that as P6

@halecatherine
Copy link

I was trying to work out which sub-mosaic each source was in and extract some pixel values at its position, so I can write a wrap around to convert from the truncated Mosaic_ID to ###-mosaic.fits.

I think maybe if you are using the P11Hetdex12 name in the mosaic images/rms maps etc it might be better using P11Hetdex12 that P11Hetdex but that is just my opinion.

@twshimwell
Copy link
Collaborator

twshimwell commented Feb 1, 2018

OK, ill remake the catalogue with the names that match the mosaic images.

@mhardcastle
Copy link
Owner

I agree with Catherine that we should use the names that correspond to the image names. And since we have already released the images we are stuck with any slight inconsistencies in naming at this point...

Tim, can you let me know when you have the new merged pybdsf catalogue because there are several outstanding issues that depend on using it.

Catherine, the code in this repository utils/get_fits.py (specifically the last 4 lines or so and the LofarMaps class it imports) will get you a subimage at any given RA and Dec by directly parsing the FITS headers of the mosaic images (assuming you have a complete download of all of them).

@twshimwell
Copy link
Collaborator

ive sent it over.

@twshimwell
Copy link
Collaborator

twshimwell commented Feb 1, 2018

The ones I just sent dont have the masked fraction (and other columns i appended) so im just adding that in.

@twshimwell
Copy link
Collaborator

ok ive sent the new one. Let me know if any issues. I've checked that all values in all the columns are the same (besides Mosaic_ID where only 172311 entries are the same)

@mhardcastle
Copy link
Owner

Should be fixed in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants