Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove options maxItemSizeKb #175

Open
reconbot opened this issue Sep 4, 2023 · 1 comment
Open

remove options maxItemSizeKb #175

reconbot opened this issue Sep 4, 2023 · 1 comment

Comments

@reconbot
Copy link
Member

reconbot commented Sep 4, 2023

Is your feature request related to a problem? Please describe.
It's a hard limit on DDB, it doesn't make sense to have it configurable. A major release is an easy time to drop it.

https://github.com/architect/dynalite/blob/main/db/index.js#L12

I'm not clear how correct this default limit of 400kb is, but nobody has complained. The docs do tell a story we could test against. However nobody has complained, so it's probably close enough.

Related we might need better validation but that's a separate issue.

@ryanblock
Copy link
Member

I don't see anything from the legacy 2011-12-05 DynamoDB API that refers to configurable max item size, so barring any arcane knowledge @mhart may have to hand down on this I agree we can drop that setting in 4.0.

Related, it's lower priority but not a bad idea to add in that per-item overhead mentioned in that doc of 100b for indexing. The other features would be trickier to calculate since they haven't published how many bytes overhead are required for each feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants