JSON: comments for types, and property URLs #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems likely that, at some point over the past year, the HTML structure of the type pages changed to use a <div property="rdfs:comment"> element to embed the comment, which broke the scraper. This enables us to greatly simplify the scraping process, and to make it more consistent with properties via the use of get_inner_html(). Signed-off-by: Dan Scott <dan@coffeecode.net>
schema.org recently added URLs that resolve for properties, so let's track those as well. Signed-off-by: Dan Scott <dan@coffeecode.net>
|
+1 |
mhausenblas
added a commit
that referenced
this pull request
Dec 11, 2013
JSON: comments for types, and property URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having noticed that all types in all.json had empty comments, and that properties were missing their URL property,
I pulled these two commits together. In all likelihood, this is a matter of the schema.org site drifting away from the
old version of the scraper.
Diffing the old all.json and the new all.json shows only the expected changes.