OOP school library: decorate a class #2
Conversation
There was a problem hiding this comment.
Hi @Mhdez221993,
Good job so far!
To Highlight! 👏 🟢
✔️ Good commit messages
✔️ Descriptive Readme file
There are some issues that you still need to work on to get this project approved, but you are almost there!
Status: Requires Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
person.rb
Outdated
| end | ||
|
|
||
| def validate_name | ||
| @corrector.correct_name(@name) |
There was a problem hiding this comment.
- This method should use the corrector instance to validate and save the corrected name like,
@name = @corrector.correct_name(@name). Please kindly fix that.
There was a problem hiding this comment.
Project Approved 🚀
Hi @Mhdez221993 🥇,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Project requirements
correct_nameCorrectorinPersonon initializationPersonadd a methodvalidate_namethat uses theCorrectorinstance to validate and save the corrected nameThank you for taking the time to review my project 👍