Incompatibility with Sidekiq 7

[Earlopain]

Sidekiq recently released a beta version of their new major release.

https://www.mikeperham.com/2022/09/27/sidekiq-7.0-beta-now-available/
https://github.com/mperham/sidekiq/blob/main/docs/7.0-Upgrade.md
https://github.com/mperham/sidekiq/blob/main/docs/internals.md

The current version of this gem is not compatible with the new version, since there were large amounts of internal changes.

[mhenrixon]

Sidekiq 7 unfortunately will require a complete refactor of my gem and I just haven't been able to figure out why.

Almost every single test fails against sidekiq 7.

[johntrandall]

oof. Sounds like this is blocked for now then...

We could always use SideKiq Enterprise, which includes these features natively, rather than this 3rd party SideKiq-Uniq, but SideKiq it is expensive.

[jpcamara]

@mhenrixon I am working on changes for compatibility with Sidekiq 7. I'll open a PR with a fix for https://github.com/brpoplpush/brpoplpush-redis_script today or tomorrow, and get at least an in-progress PR for sidekiq-unique-jobs within the next few days.

[jpcamara]

I am working on changes for compatibility with Sidekiq 7. I'll open a PR with a fix for https://github.com/brpoplpush/brpoplpush-redis_script today or tomorrow, and get at least an in-progress PR for sidekiq-unique-jobs within the next few days.

There are some larger architectural decisions that may be made by @mhenrixon in response to the Sidekiq/Redis gem updates, so i'm not actively working on this atm

[marclennox]

I'm curious what is the plan for Sidekiq 7 support with this gem? We've been using this gem with Sidekiq 6 for a while but will likely need to plan for another solution if Sidekiq 7 support is unlikely. Thanks.

[mhenrixon]

All the tests are failing and i simply haven't had the bandwidth to look into it.

I tried and failed in one branch and haven't had time to look into it.

[mhenrixon]

#751

[knightq]

Thank you @mhenrixon, is this going to be closed, then?
I've seen that you merged PR#751 yesterday...

[slhck]

@knightq There is still no new release. I'd be happy to test the upgrade though.

[mhenrixon]

Currently doing some QA for this

[knightq]

Thank you @mhenrixon ❤️: the new version works like a charm!
I think this issue can be closed now.

[mhenrixon]

Closing