Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should client middleware also be added to the Sidekiq server config? #803

Closed
gstokkink opened this issue Aug 7, 2023 · 2 comments
Closed

Comments

@gstokkink
Copy link

Hi,

In the installation instructions, under Add the middleware, it states the following bit twice, once under the server config and once under the client config:

  config.client_middleware do |chain|
    chain.add SidekiqUniqueJobs::Middleware::Client
  end

Is this correct? You'd expect client middleware to only be configured on the Sidekiq client, right?

@mhenrixon
Copy link
Owner

That's correct, the server also acts as a client when solving conflicts etc.

@gstokkink
Copy link
Author

gstokkink commented Aug 7, 2023

Alright, just checking, thanks for your quick reply!

Edit: actually, I wanted to make a discussion for this but accidently created an issue instead. Apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants