Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored growl reporter. #296

Merged
merged 1 commit into from
Mar 7, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ what's new
* Rewrote Terminal Reporter
* Removed TeamCity Reporter (no support for Jasmine 2.0)
* Removed JUnit Reporter (no support for Jasmine 2.0)
* Removed Growl Reporter (no support for Jasmine 2.0)

install
------
Expand Down
11 changes: 7 additions & 4 deletions lib/jasmine-node/cli.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion lib/jasmine-node/jasmine-loader.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
"underscore": "~1.6.0",
"gaze": "~0.5.1",
"mkdirp": "~0.3.5",
"minimist": "0.0.8"
"minimist": "0.0.8",
"jasmine-growl-reporter": "~0.2.0"
},
"devDependencies": {
"grunt-contrib-coffee": "^0.10.1",
Expand Down
8 changes: 4 additions & 4 deletions src/cli.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Options:
-m, --match REGEXP - load only specs containing "REGEXPspec"
--matchAll - relax requirement of "spec" in spec file names
--verbose - print extra information per each test run
--growl - display test run summary in a growl notification (in addition to other outputs)
--coffee - load coffee-script which allows execution .coffee files
--forceExit - force exit once tests complete.
--captureExceptions- listen to global exceptions, report them and exit (interferes with Domains)
Expand All @@ -30,7 +31,6 @@ Options:

# --testDir - the absolute root directory path where tests are located
# --config NAME VALUE- set a global variable in process.env
# --growl - display test run summary in a growl notification (in addition to other outputs)
process.exit -1

printVersion = ->
Expand All @@ -44,7 +44,7 @@ jasmine.setInterval = jasmine.getGlobal().setInterval
global[key] = value for key, value of jasmine

exitCode = 0
# growl = false
growl = false

minimistOpts =
boolean: [
Expand All @@ -56,7 +56,7 @@ minimistOpts =
"noColor"
"noStackTrace"
"verbose"
# "growl"
"growl"
]
string: [
"watch"
Expand All @@ -75,7 +75,7 @@ minimistOpts =
noColor : false
noStackTrace : false
verbose : false
# growl : false
growl : false

args = minimist process.argv.slice(2), minimistOpts

Expand Down
8 changes: 4 additions & 4 deletions src/jasmine-loader.coffee
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
_ = require 'underscore'
fs = require 'fs'
#growlReporter = require 'jasmine-growl-reporter'
growlReporter = require 'jasmine-growl-reporter'
mkdirp = require 'mkdirp'
path = require 'path'
util = require 'util'
Expand Down Expand Up @@ -32,7 +32,7 @@ jasmine = vm.runInThisContext "#{bootSrc}\njasmine = window.jasmine;", bootjs
delete global.window unless isWindowDefined

jasmine.TerminalReporter = nodeReporters.TerminalReporter
# jasmine.GrowlReporter = growlReporter
jasmine.GrowlReporter = growlReporter

# Define helper functions
jasmine.loadHelpersInFolder = (folder, matcher) ->
Expand Down Expand Up @@ -85,8 +85,8 @@ jasmine.executeSpecsInFolder = (options) ->

jasmineEnv.addReporter new jasmine.TerminalReporter reporterOptions

# if options.growl?
# jasmineEnv.addReporter new jasmine.GrowlReporter()
if options.growl
jasmineEnv.addReporter new jasmine.GrowlReporter(options.growl)

specsList = specs.getSpecs()

Expand Down