hs2.LoadDetected() crashes when no spikes were detected

[JanoHorvath]

If the file_name (usually ProcessedSpikes.bin) is a path to an empty file, LoadDetected() crashes with ValueError: cannot mmap an empty file

Instead, it should just fill self.spikes dataframe with empty values.

[martinosorb]

Wait, if it's empty something is wrong, it's ok to throw an error...

[JanoHorvath]

I agree, however it shouldn't crash the whole execution. How about a warning?

I am doing some automatic parameter optimisation, and sometimes I need to initialize parameters to something ridiculous (e.g. maxsl = 1 ). In that case I would like the program to handle this graciously.

[martinosorb]

I see what you mean. Do you actually need to load the detected spikes for that?

Incidentally, while you are at it, could you check if there are redundant parameters passed to the detection function? I don't even know what these parameters mean and it should be documented.

[JanoHorvath]

Yes, unfortunately I do need to load them. I've created a pull request with my code suggestion, what do you think?

I can check, no problem. Do you mean on python level, or cpp level?