Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review example notebooks #27

Closed
martinosorb opened this issue May 20, 2018 · 10 comments
Closed

Review example notebooks #27

martinosorb opened this issue May 20, 2018 · 10 comments
Assignees
Milestone

Comments

@martinosorb
Copy link
Collaborator

  • Where possible, add a wget command that downloads a publicly available dataset for analysis.
  • Find reasonable values for the clustering parameters, so that the result actually looks usable. At the moment, in all the examples, the result that gets plotted is a big red blob of 1 cluster, or similar.
@martinosorb martinosorb added this to the First Release milestone May 20, 2018
@mhhennig
Copy link
Owner

Great idea, I'll do that for biocam and neuropixel.

  • How about MEA1k and Neuroseeker?
  • Is it correct that the Neuroseeker reader is actually for a converted/filtered file?
  • Do we have an URL for the Visapy data?

@mhhennig mhhennig self-assigned this May 20, 2018
@mhhennig
Copy link
Owner

Made a notebook for Neuropixel with data download, please check:
https://github.com/mhhennig/HS2/blob/master/notebooks/localised_spikes_clustered-neuropixel.ipynb

@martinosorb
Copy link
Collaborator Author

I cleared the notebook output and changed the download method: the problem is that the request package is not built in, would need to be pip-installed...

@mhhennig
Copy link
Owner

Great, thanks. However:
file_name = "data/neuropixelRaw.bin"
Does this work if data does not exist?

@martinosorb
Copy link
Collaborator Author

Indeed it doesn't. At the next update I'll change that.

@mhhennig
Copy link
Owner

ViSAPy notebook ready too, plz test...hell, urllib is a pain!

@mhhennig
Copy link
Owner

...and a biocam notebook ready for testing too.

@mhhennig
Copy link
Owner

mhhennig commented Jun 1, 2018

Notebooks complete now. I wonder whether we should leave the images in them as it's also a nice demo, and github renders them well..?

@martinosorb
Copy link
Collaborator Author

Sorry, I didn't read them and I removed them (it messes up when merging). We can give them another run later when everything is done.

@martinosorb
Copy link
Collaborator Author

Is this done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants