Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions #25

Closed
PushkarOP opened this issue Oct 16, 2021 · 3 comments
Closed

Suggestions #25

PushkarOP opened this issue Oct 16, 2021 · 3 comments

Comments

@PushkarOP
Copy link

Maybe try to add item rarity lore like hypixel have , COMMON ,RARE Like this
@MHIGists
Copy link
Owner

Maybe try to add item rarity lore like hypixel have , COMMON ,RARE Like this

That sounds interesting. However there are some things I don't know. Do these items get crafted or are they perhaps awarded/bought. What should be a, let's say EPIC item for example an EPIC sword?

@PushkarOP
Copy link
Author

PushkarOP commented Oct 17, 2021 •
edited
Loading

Maybe try to add item rarity lore like hypixel have , COMMON ,RARE Like this

That sounds interesting. However there are some things I don't know. Do these items get crafted or are they perhaps awarded/bought. What should be a, let's say EPIC item for example an EPIC sword?

Hmm like normal diamond sword will be Rare then if we put enchantment it will become Epic

MHIGists added a commit that referenced this issue Oct 18, 2021
@MHIGists
The Base Idea for #25
1cf554f
@MHIGists
Copy link
Owner

You can follow any ongoing progress on the ItemsRarity-Sets branch! Good idea hope there are more people joining 🥇
https://github.com/MHIGists/RPGLike/tree/ItemRarity-Sets

MHIGists added a commit that referenced this issue Dec 8, 2021
@MHIGists
Squashed commit of the following:
eecc33d 
commit ed1c94a
Author: M.Ivanov <milko.hristov.ivanov65@gmail.com>
Date:   Wed Dec 8 14:35:00 2021 +0200

    api 4.0 refactor

commit 8e41f87
Author: M.Ivanov <milko.hristov.ivanov65@gmail.com>
Date:   Sat Oct 23 00:38:58 2021 +0300

    That's the solution for now

    Maybe we can join BaseCustomArmor and BaseTieritem into one Trait... Needs more tests

commit d2624b4
Author: M.Ivanov <milko.hristov.ivanov65@gmail.com>
Date:   Fri Oct 22 17:19:22 2021 +0300

    Something more humane

    Finally an idea for these custom items. Needs to be finished though

commit a3fcc8e
Author: M.Ivanov <milko.hristov.ivanov65@gmail.com>
Date:   Thu Oct 21 17:22:31 2021 +0300

    Don't like this whole thing

    ...This will be reworked. I don't like every bit of it. Saving to work on the code at home

commit 968aaaa
Author: M.Ivanov <milko.hristov.ivanov65@gmail.com>
Date:   Wed Oct 20 17:12:07 2021 +0300

    BaseTieredItem will be a trait used by the different items. In order to extend an Item class and have all the reused code.

commit 876aadc
Author: M.Ivanov <milko.hristov.ivanov65@gmail.com>
Date:   Tue Oct 19 16:47:58 2021 +0300

    More work on the tier system

    Examples on how the system should work added. Next step is building the BaseTierItems class and coming up with more ideas for item sets.

commit 1cf554f
Author: M.Ivanov <milko.hristov.ivanov65@gmail.com>
Date:   Mon Oct 18 14:58:43 2021 +0300

    The Base Idea for #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MHIGists @PushkarOP