Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signify significantly slows saving a file. #71

Closed
MarioRicalde opened this issue Sep 19, 2013 · 6 comments
Closed

Signify significantly slows saving a file. #71

MarioRicalde opened this issue Sep 19, 2013 · 6 comments

Comments

@MarioRicalde
Copy link

When saving a file with a certain number of changes, slows save by 3-4 seconds.

Profiling:
https://gist.github.com/6619893

Number of signs added by Signify:
https://dl.dropboxusercontent.com/s/vr1le1j07ha8wvz/2013-09-19%20at%201.58%20AM.png

@mhinz
Copy link
Owner

mhinz commented Sep 19, 2013

That doesn't look good. Have you set any signify variables?

Especially g:signify_sign_overwrite would be interesting, because it defaults to 1. Which means that sy#sign#remove_all() would just do a simple sign unplace *, which shouldn't take longer than some miliseconds.

And just to be sure, could you remove the ShowMarks plugin and try again?

@MarioRicalde
Copy link
Author

I'm using the following signify variables:

let g:signify_sign_add = '+'
let g:signify_sign_change = '~'
let g:signify_sign_delete = '_'
let g:signify_sign_delete_first_line = '‾'

█ Mario "Kuroir" Ricalde
_█ *_Front-end Engineer *
_█ _kuroir@twitter
*█ *+1 ‪(415) 800-415-4‬

On Thu, Sep 19, 2013 at 9:12 AM, Marco Hinz notifications@github.comwrote:

That doesn't look good. Have you set any signify variables?

Especially g:signify_sign_overwrite, because it defaults to 1. Which
means that sy#sign#remove_all() would just do a simple sign unplace *,
which shouldn't take longer than some miliseconds.


Reply to this email directly or view it on GitHubhttps://github.com//issues/71#issuecomment-24741361
.

@mhinz
Copy link
Owner

mhinz commented Sep 20, 2013

What about removing the ShowMarks plugin? I just want to rule out any interference of other sign setting plugins. Especially because its functions get called pretty often.

There must be something broken, because I see no reason why sy#sign#remove_all() would ever take any onger than some fractions of a second, let alone over 2 seconds. Now we have to find the culprit!

@mhinz
Copy link
Owner

mhinz commented Sep 30, 2013

ping

Did you try removing the ShowMarks plugin?

Moreover, :version:

VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Sep 19 2013 12:58:11)
Included patches: 1-27

This means I'm using 7.4.27. What version do you use?

@MarioRicalde
Copy link
Author

I haven't been able to deal with another heavy changed file for a while,
will do later today.

Will keep you posted.

█ Mario "Kuroir" Ricalde
_█ *_Front-end Engineer *
_█ _kuroir@twitter
*█ *+1 ‪(415) 800-415-4‬

On Mon, Sep 30, 2013 at 3:29 AM, Marco Hinz notifications@github.comwrote:

ping


Reply to this email directly or view it on GitHubhttps://github.com//issues/71#issuecomment-25344512
.

@mhinz
Copy link
Owner

mhinz commented Nov 19, 2013

(Please reopen if necessary.)

@mhinz mhinz closed this as completed Nov 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants