Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep permissions on unzipped folders #133

Closed
heycait opened this issue Jan 1, 2019 · 1 comment
Closed

Keep permissions on unzipped folders #133

heycait opened this issue Jan 1, 2019 · 1 comment
Labels

Comments

@heycait
Copy link
Contributor

heycait commented Jan 1, 2019

What would you like to have changed?

Retain the permissions when unzipping folders instead of hardcoding to 0755

Why is this feature a useful, necessary, and/or important addition to this project?

This feature is useful to maintain file integrity. It's unexpected that unzipping files changes it's permissions.

What alternatives are there, or what are you doing in the meantime to work around the lack of this feature?

Our workaround has been using git to set the core.filemode to false, which requires us to unnecessarily include git.

@heycait heycait changed the title Keep permissions on unzipped files Keep permissions on unzipped folders Jan 2, 2019
@mholt
Copy link
Owner

mholt commented Jan 9, 2019

Thanks for reporting the issue and submitting a fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants