Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation update #18

Closed
potto216 opened this issue Jul 20, 2019 · 4 comments
Closed

Minor documentation update #18

potto216 opened this issue Jul 20, 2019 · 4 comments

Comments

@potto216
Copy link
Contributor

First off, thanks for writing the software! It works well with my RTL-SDR. If the project is still being maintained I can create a pull request to update the readme with some suggestions. They would be:

  1. Add pip install zmq and pmt
  2. To prevent accidentally messing up the user's root python environment have optional instructions to use pipenv.
@mhostetter
Copy link
Owner

You're very welcome. I'm happy to hear it's working and being used 😄

While I haven't directly developed on this project in a couple years, I still track/maintain it. Also, I have plans to update the code (both demodulator and ADS-B decoder) when I upgrade this project to GNU Radio 3.8. I would absolutely welcome a pull request. Thanks for using the software.

@potto216
Copy link
Contributor Author

Great! Will do, yeah moving over to 3.8 will be interesting with the Python 3 and YAML changes.

@potto216 potto216 mentioned this issue Jul 21, 2019
@potto216
Copy link
Contributor Author

If you open a new issue for updating the demodulator I would like to help. From what I've read ADS-B is basically transmitting a form of on off keying (which I found shocking) that explains why you are doing incoherent demod. Can you improve the performance with coherent demod? I did a quick Google Scholar search and found a few articles, but I'm not sure what the constraints are.

@mhostetter
Copy link
Owner

I like the demod conversation. I'm going to move that conversation to #21 and close this issue since you already submitted PR #20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants