Add module-info.java

[robertvazan]

Please add module-info.java. It will ease use of the library in dependent libraries and applications that are using Java 9 modules. In order to do this, you either have to upgrade to Java 9+ or create multi-release JAR. Given how old Java 8 is, I would recommend upgrading to Java 9 or even Java 11. It's much simpler than building multi-release JARs. Java 8 libs and apps can keep using older versions of the library.

[robertvazan]

PS: Probably the easiest thing to do is to make jnbis an automatic module.

[mhshams]

Possibly implemented in v2.1.0. need verification.

I've done a quick check and it seemed ok.

[robertvazan]

This wouldn't build, at least not under Java 17. Try to run mvn package or mvn install locally. A number of plugins (at least source & javadoc) need to be updated to their latest version. After that, I get moditect error:

[ERROR] Failed to execute goal org.moditect:moditect-maven-plugin:1.0.0.RC2:add-module-info (add-module-info) on project jnbis: Execution add-module-info of goal org.moditect:moditect-maven-plugin:1.0.0.RC2:add-module-info failed: Couldn't parse /home/rv/Workspace/eclipse/jnbis/target/moditect/jnbis/module-info.java -> [Help 1]

Moditect plugin seems misconfigured. It seems to expect module-info.java under src/moditect (example) with only short config in pom.xml (example).

[robertvazan]

I have also tried the prebuilt binary from Maven Central. That one has valid module-info.java, but it does not export org.jnbis.api package, only its subpackages. Please add the package to moditect config.

[mhshams]

This wouldn't build, at least not under Java 17. Try to run mvn package or mvn install locally. A number of plugins (at least source & javadoc) need to be updated to their latest version. After that, I get moditect error:

[ERROR] Failed to execute goal org.moditect:moditect-maven-plugin:1.0.0.RC2:add-module-info (add-module-info) on project jnbis: Execution add-module-info of goal org.moditect:moditect-maven-plugin:1.0.0.RC2:add-module-info failed: Couldn't parse /home/rv/Workspace/eclipse/jnbis/target/moditect/jnbis/module-info.java -> [Help 1]

Moditect plugin seems misconfigured. It seems to expect module-info.java under src/moditect (example) with only short config in pom.xml (example).

I'd built the module with java 11 both locally and in the pipeline (github actions).

I tried java 17 and had the same issue with the plugins. after updating them build is green now. If you are tying the build locally, don't forget to clean before package or install .

[mhshams]

I have also tried the prebuilt binary from Maven Central. That one has valid module-info.java, but it does not export org.jnbis.api package, only its subpackages. Please add the package to moditect config.

sorry about this. I had to check the plugin patterns carefully. It's fixed now and i'll push a patch release today.

[robertvazan]

I just tested it and it works. Thank you.