Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinysoap-browser-min.js problem running with requirejs.org #11

Open
hhkaos opened this issue Aug 6, 2020 · 0 comments
Open

tinysoap-browser-min.js problem running with requirejs.org #11

hhkaos opened this issue Aug 6, 2020 · 0 comments

Comments

@hhkaos
Copy link

hhkaos commented Aug 6, 2020

Hi there!,

First of all, thank you for the amazing work you have done! 💪 .

I'm just opening this issue because I have been playing around with this library and I have noticed there is a problem at the begging of the script. When it checks if typeof require === undefined while the requirejs library is loaded it fails because it tries to load NodeJS core modules.

Would it make sense to replace that condition for something like this: if (typeof window === 'undefined')? If you think it does I'll be have to send a PR.

You can see more at this thread

Best regards,
Raul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant