Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ic-page-header] storybook accessibility plug in complaining of two elements with role="banner" #1908

Open
GCHQ-Developer-530 opened this issue May 23, 2024 · 0 comments
Labels
type: bug 馃悰 Something isn't working

Comments

@GCHQ-Developer-530
Copy link
Contributor

Summary of the bug

On storybook examples of page header with top nav, the built in storybook accessibility plug in is failing due to two elements having a banner role and all roles should be unique.

馃獪 How to reproduce

Tell us the steps to reproduce the problem:

  1. Go to page-header sticky-with-content-and-footer example
  2. Click on accessibility plug in in the drawer
  3. See the error

馃摳 Screenshots or code

Screenshot 2024-05-23 at 14 38 12

馃 Expected behaviour

It should only have one banner.

Additional info

Weirdly page header doesn't have a banner role. This doesn't fail accessibility insights fast pass either so it's hard to tell if it's a weird quirk of storybook or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 馃悰 Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant