Side navigation bug fixes #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/bugfix/739-empty-side-nav-when-changing-screen-widths/web-components |
GCHQ-Developer-847
force-pushed
the
bugfix/739-empty-side-nav-when-changing-screen-widths
branch
from
a36fe8d
to
fc277a9
Compare
GCHQ-Developer-530
previously approved these changes
Jul 18, 2023
GCHQ-Developer-741
previously approved these changes
Jul 18, 2023
jd239
requested changes
Jul 18, 2023
| private animateCollapsedIconLabels = () => { | ||
| this.transitionEndHandler(); | ||
| this.transitionHandler("start"); | ||
| this.transitionHandler("end"); |
There was a problem hiding this comment.
Can use your new transitionEndHandler method here..or if it's only being used once, delete the new method.
GCHQ-Developer-847
dismissed stale reviews from GCHQ-Developer-741 and GCHQ-Developer-530
via
a995f43
GCHQ-Developer-847
force-pushed
the
bugfix/739-empty-side-nav-when-changing-screen-widths
branch
2 times, most recently
from
a995f43
to
da9863b
Compare
GCHQ-Developer-530
approved these changes
Jul 18, 2023
… content is correct Update side navigation CSS so that the visibility is handled by just the 'menu-visibility-visible' class instead of in the media query, remove unused classes in ic-navigation-group CSS. .#739
Fix padding on static side navigation variant so content is pushed to the side the correct amount. .#885
…ith collapsed labels variant Update side navigation transition handlers to fix bug with collapsed labels variant not showing navigation items - re-add functionality for adding / removing classes on transition start. .#896
GCHQ-Developer-847
force-pushed
the
bugfix/739-empty-side-nav-when-changing-screen-widths
branch
from
da9863b
to
e70779a
Compare
jd239
approved these changes
Jul 18, 2023
GCHQ-Developer-847
deleted the
bugfix/739-empty-side-nav-when-changing-screen-widths
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
For #739: Updated CSS so that the visibility is handled by just the 'menu-visibility-visible' class instead of in the media query, and remove unused classes in ic-navigation-group CSS.
For #885: Fixed padding so content is pushed to the side the correct amount with static variant.
For #896: Updated transition handlers - re-added functionality for adding / removing classes on transition start.
Related issue
#739, #885 and #896.
Checklist