-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Side navigation bug fixes #910
Side navigation bug fixes #910
Conversation
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/bugfix/739-empty-side-nav-when-changing-screen-widths/web-components |
a36fe8d
to
fc277a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment. Good work on the side navigation! :)
private animateCollapsedIconLabels = () => { | ||
this.transitionEndHandler(); | ||
this.transitionHandler("start"); | ||
this.transitionHandler("end"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can use your new transitionEndHandler
method here..or if it's only being used once, delete the new method.
a995f43
a995f43
to
da9863b
Compare
… content is correct Update side navigation CSS so that the visibility is handled by just the 'menu-visibility-visible' class instead of in the media query, remove unused classes in ic-navigation-group CSS. .#739
Fix padding on static side navigation variant so content is pushed to the side the correct amount. .#885
…ith collapsed labels variant Update side navigation transition handlers to fix bug with collapsed labels variant not showing navigation items - re-add functionality for adding / removing classes on transition start. .#896
da9863b
to
e70779a
Compare
Summary of the changes
For #739: Updated CSS so that the visibility is handled by just the 'menu-visibility-visible' class instead of in the media query, and remove unused classes in ic-navigation-group CSS.
For #885: Fixed padding so content is pushed to the side the correct amount with static variant.
For #896: Updated transition handlers - re-added functionality for adding / removing classes on transition start.
Related issue
#739, #885 and #896.
Checklist