Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsed with labels side navigation variant stops showing navigation items after it is expanded #896

Closed
GCHQ-Developer-847 opened this issue Jul 14, 2023 · 1 comment
Labels
side-navigation component The generic component, includes both the web component and the React component

Comments

@GCHQ-Developer-847
Copy link
Contributor

Summary of the bug

When you open a side navigation component which has labels visible when it is collapsed (i.e. collapsed-icon-labels set to true), the navigation items disappear when you expand it.

🪜 How to reproduce

Tell us the steps to reproduce the problem:

  1. Go to the 'Collapsed labels' example in the 'Code' tab on the side navigation page.
  2. Expand the side navigation.
  3. The navigation items disappear, and they are no longer visible when you collapse it again.

🧐 Expected behaviour

The navigation items should not disappear.

📸 Screenshots or code

🖥 Desktop

  • Browser: Chrome, Safari, Firefox
@GCHQ-Developer-847 GCHQ-Developer-847 added the side-navigation component The generic component, includes both the web component and the React component label Jul 14, 2023
GCHQ-Developer-847 added a commit that referenced this issue Jul 17, 2023
…ith collapsed labels variant

Update side navigation transition handlers to fix bug with collapsed labels variant not showing
navigation items - re-add functionality for adding / removing classes on transition start.

.#896
GCHQ-Developer-847 added a commit that referenced this issue Jul 17, 2023
…ith collapsed labels variant

Update side navigation transition handlers to fix bug with collapsed labels variant not showing
navigation items - re-add functionality for adding / removing classes on transition start.

.#896
GCHQ-Developer-847 added a commit that referenced this issue Jul 17, 2023
…ith collapsed labels variant

Update side navigation transition handlers to fix bug with collapsed labels variant not showing
navigation items - re-add functionality for adding / removing classes on transition start.

.#896
GCHQ-Developer-847 added a commit that referenced this issue Jul 18, 2023
…ith collapsed labels variant

Update side navigation transition handlers to fix bug with collapsed labels variant not showing
navigation items - re-add functionality for adding / removing classes on transition start.

.#896
GCHQ-Developer-847 added a commit that referenced this issue Jul 18, 2023
…ith collapsed labels variant

Update side navigation transition handlers to fix bug with collapsed labels variant not showing
navigation items - re-add functionality for adding / removing classes on transition start.

.#896
GCHQ-Developer-847 added a commit that referenced this issue Jul 18, 2023
…ith collapsed labels variant

Update side navigation transition handlers to fix bug with collapsed labels variant not showing
navigation items - re-add functionality for adding / removing classes on transition start.

.#896
GCHQ-Developer-847 added a commit that referenced this issue Jul 18, 2023
…ith collapsed labels variant

Update side navigation transition handlers to fix bug with collapsed labels variant not showing
navigation items - re-add functionality for adding / removing classes on transition start.

.#896
@GCHQ-Developer-847
Copy link
Contributor Author

Fixed as part of PR #910

GCHQ-Developer-530 pushed a commit that referenced this issue Jul 20, 2023
…ith collapsed labels variant

Update side navigation transition handlers to fix bug with collapsed labels variant not showing
navigation items - re-add functionality for adding / removing classes on transition start.

.#896
GCHQ-Developer-530 pushed a commit that referenced this issue Jul 21, 2023
…ith collapsed labels variant

Update side navigation transition handlers to fix bug with collapsed labels variant not showing
navigation items - re-add functionality for adding / removing classes on transition start.

.#896
jd239 pushed a commit that referenced this issue Jul 24, 2023
…ith collapsed labels variant

Update side navigation transition handlers to fix bug with collapsed labels variant not showing
navigation items - re-add functionality for adding / removing classes on transition start.

.#896
jd239 pushed a commit that referenced this issue Jul 24, 2023
…ith collapsed labels variant

Update side navigation transition handlers to fix bug with collapsed labels variant not showing
navigation items - re-add functionality for adding / removing classes on transition start.

.#896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
side-navigation component The generic component, includes both the web component and the React component
Projects
Development

No branches or pull requests

1 participant