-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opens a non-Tor Firefox window, if Firefox is already running #157
Comments
Sorry about the stupid late response. I'm testing in Debian and I can't reproduce. I have Iceweasel open, and when I open Tor Browser Launcher it opens a new Tor Browser window. I also have Tor Browser set as my default browser. When I close the Tor Browser window and click a link in some other program, it opens the link in a new Tor Browser and ignores Iceweasel. Can you give more details on how to reproduce? |
To reproduce:
Like you, I can't reproduce this with iceweasel (but I generally don't run iceweasel, because it's based on ESR rather than the latest Firefox). |
I can reproduce this bug in Ubuntu with Firefox installed from the default repository. |
I have just upgraded to
With |
I don't use Firefox on a regular basis, so haven't been noticing this one. But with the 0.1.8, this is an urgent issue to fix. Working on it. |
The problem is boils down to the Basically, firefox has a command line argument, If you want to be able to pass URLs into an already-open Tor Browser process, then you must run But if you have a non-Tor Browser firefox process open in the background, and you run The reason that this issue doesn't affect Debian when Iceweasel is open is, I'm pretty sure, because the Iceweasel process is called I'm trying to figure out how to deal with this. I've already tried renaming I'm worried that without an upstream patch to the firefox that comes with Tor Browser, it might not be possible to resolve this issue without removing the capability to open URLs in Tor Browser. A workaround, of course, is to stop using Firefox and switch to Chromium or something as your non-Tor browser. |
Also, this has been an issue since I introduced the ability to pass URLs into Tor Browser. It was just less noticable due to another bug. If you opened Tor Browser for the first time by clicking a link, then you could continue to click more links to open new tabs. However if you opened Tor Browser the first time by just opening it, it wouldn't open with This commit de13483 fixed it. But also made it so when you open Tor Browser at all, if firefox is open in the background, it instead opens a new tab in firefox. |
So it seems to be that the choices are:
Anything else? |
@micahflee the latest update ( |
Yes, it should be 100% worked around at this point. But it's still a shame that you can't set Tor Browser as your default browser and use Firefox at the same time. I plan on opening an upstream TBB bug about this (when you run |
To rename the firefox binary to torbrowser, upstream would need to pass |
In TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD} ./firefox --class "Tor Browser" \
-profile TorBrowser/Data/Browser/profile.default "${@}"
exitcode="$?" If I copy TOR_CONTROL_PASSWD=${TOR_CONTROL_PASSWD} ./torbrowser --with-app-name=torbrowser --with-app-basename=torbrowser --class "Tor Browser" \
-profile TorBrowser/Data/Browser/profile.default "${@}"
exitcode="$?" It still appears to act the same way. If Firefox is open in the background and I run I haven't actually confirmed that the reason it opens a Firefox tab is because of the process name -- there could be something different there. |
and in another terminal
this is a torbrowser built on gentoo with some additional options passed to configure: https://github.com/MeisterP/torbrowser-overlay/blob/master/www-client/torbrowser/torbrowser-31.4.0.ebuild#L169 Edit: |
In the TBB 4.5 they updated the star-tor-browser script, which actually removed support for passing |
When we looked at the history of issues about opening links with TorBrowser, we found torproject#103 where initially the feature to open links from other applications was added. Then some months later, the feature was removed again, as it was not working because of torproject#157 and torproject#175. The issues was back then (~4years ago), that when users had a normal Firefox running, urls got opened in the normal firefox insead of TorBrowser. That was because TorBrowser had the --no-remote flag set deep down in their code. In the meanwhile TorBrowser removed the explicit --no-remote flag, so we are able to use --allow-remote again. On top of that there is another issue when we want open urls with TorBrowser: If the LOGNAME is the same as the LOGNAME of the opened firefox, urls are still opened in the open firefox. But if we set the LOGNAME envrionment variable explicitly, we can make sure, that the url opens in the TorBrowser instead of a running Firefox. Should fix: torproject#245, torproject#259, torproject#380
Since the last update (nominally 0.1.6-1 -> 0.1.7-1, but I'm building from git), torbrowser-launcher has stopped working if Firefox is already running. Instead, it just opens a new window from the currently running FF profile.
The text was updated successfully, but these errors were encountered: