Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResNet encoder in WENO #3

Open
cswpy opened this issue Apr 26, 2023 · 0 comments
Open

ResNet encoder in WENO #3

cswpy opened this issue Apr 26, 2023 · 0 comments

Comments

@cswpy
Copy link

cswpy commented Apr 26, 2023

First of all, thank you for your work. I was checking the code after reading the paper and have some doubts regarding the implementation.

  1. The paper said that all datasets except for CIFAR-10-MIL used ResNet18. However, it seems that the CAMELYON model used camelyon_feat_projecter from AlexNet as the encoder, which is a linear layer with BatchNorm. I understand that the features were already extracted by SimCLR. Does this mean by the encoder in this case is just the feature_projecter? Additionally, the dataset_CAMELYON16_BasedOnFeat seems to be filtering patches, i.e. only considering positive patches in positive bags and negative patches in negative bags. Is there a reason behind that?
  2. I am a bit confused about loading the pre-trained features part in dataset_CAMELYON16_BasedOnFeat.py. Specifically, lines 74-77 are shown below.
    if train:
    all_slides_feat_file = glob.glob("")
    else:
    all_slides_feat_file = glob.glob("")

Also, I see that you are reading the pre-trained features on line 90. Could you clarify about the file structure of those files? (file formats, naming, directory structures, etc.)

  1. ResNetv2 is implemented in the codebase but not used in the paper, is there a reason behind this?
  2. The DSMIL+WENO implementation has SimCLR in it. If I understood correctly, the WENO framework will share a pre-trained encoder and will continue to update the weights in the encoder. I am considering using a pre-trained ResNet50 inside WENO, do you think this is a good idea?

I know it's a lot of questions. But it would be great if you could answer them. Again, thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant