Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation problems with Visual C++ 2017 #23

Open
dasmysh opened this issue Jul 12, 2017 · 1 comment
Open

Compilation problems with Visual C++ 2017 #23

dasmysh opened this issue Jul 12, 2017 · 1 comment

Comments

@dasmysh
Copy link

dasmysh commented Jul 12, 2017

When compiling the code in Visual Studio 2017 I got an error in file densevector.h. For some reason VS does not understand Engine::defaultIndexBase.

This can be fixed easily by adding a new constant to the class:
static const IndexType defaultIndexBase = Engine::defaultIndexBase;

The method declaration of resize can then refer to that constant.

@dasmysh
Copy link
Author

dasmysh commented Jul 12, 2017

There also is a warning in file ilaenv.tcc that could possibly lead to an error.

Please use the correct casts to avoid any numerical problems.

Possible solution is to change line 376 to:
result = static_cast<int>(static_cast<double>(nx)/1.5);

I'm not sure if that is the correct and intended behavior though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant